Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate AWS SDK for JavaScript v2 APIs to v3 in scripts folder #28249

Merged
merged 10 commits into from
Nov 21, 2023
Merged

chore: migrate AWS SDK for JavaScript v2 APIs to v3 in scripts folder #28249

merged 10 commits into from
Nov 21, 2023

Conversation

trivikr
Copy link
Contributor

@trivikr trivikr commented Nov 6, 2023 •
edited
Loading

Additional details

From AWS SDK for JavaScript v2 README:

We are formalizing our plans to make the Maintenance Announcement (Phase 2) for AWS SDK for JavaScript v2 in 2023.

This PR migrates AWS SDK for JavaScript v2 APIs to v3 using aws-sdk-js-codemod.

$ npx [email protected] -t v2-to-v3 scripts/binary/s3-api.ts

Steps to test

N/A

How has the user experience changed?

N/A

PR Tasks

@CLAassistant
Copy link

CLAassistant commented Nov 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link
Collaborator

@trivikr trivikr marked this pull request as ready for review November 6, 2023 01:52
@emilyrohrbough emilyrohrbough changed the base branch from develop to contributor-prs November 6, 2023 22:36
@trivikr
Copy link
Contributor Author

trivikr commented Nov 13, 2023

cc active contributors @emilyrohrbough @jennifer-shehane

emilyrohrbough
emilyrohrbough reviewed Nov 14, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
@emilyrohrbough emilyrohrbough changed the base branch from contributor-prs to develop November 20, 2023 17:04
@jennifer-shehane jennifer-shehane merged commit 537642a into cypress-io:develop Nov 21, 2023
64 of 66 checks passed
@trivikr trivikr deleted the aws-sdk-js-codemod branch November 21, 2023 05:31
@jordanpowell88 jordanpowell88 mentioned this pull request Nov 21, 2023
Merged
@jordanpowell88
Copy link
Contributor

We needed to revert this PR as it broke the CI job that uploads to S3 (see https://app.circleci.com/pipelines/github/cypress-io/cypress-publish-binary/3407/workflows/4f2225d3-8591-48d7-bb0e-d8a572e6490a/jobs/6045).

We should add this back in AND add appropriate tests to make sure this doesn't happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilyrohrbough emilyrohrbough emilyrohrbough approved these changes

@mschile mschile mschile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@trivikr @CLAassistant @cypress-app-bot @jordanpowell88 @mschile @emilyrohrbough @jennifer-shehane